Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: UI as per the suggested changes(#243) #244

Merged
merged 7 commits into from
Aug 12, 2024

Conversation

ymaheshwari1
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 commented Jul 19, 2024

Related Issues

#243

Short Description and Why It's Useful

  • Changed dynamic header on routing and rule page to static page title
  • Changed color for draft status badge to medium
  • Fixed issue of singular/plural when displaying archived routings
  • Used ion-card specific syntax when displaying routing title and id
  • Fixed issue of autoCancelDays not being displayed on initial load of rules information, if the clearAutoCancelDays is set to false
  • Improved the UI to handle the archived rules

Screenshots of Visual Changes before/after (If There Are Any)

After:

image

image

image

Contribution and Currently Important Rules Acceptance

Changed dynamic header on routing and rule page to static page title
Changed color for draft status badge to medium
Fixed issue of singular/plural when displaying archived routings
Used ion-card specific syntax when displaying routing title and id
… update the UI as per the changes(hotwax#243)

After makign some changes if the same rule if archived without saving the changes then the changes made will be lost
@ymaheshwari1 ymaheshwari1 merged commit 7bfcf04 into hotwax:main Aug 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant